Skip to content

Fix loading state of searching API #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
e-for-eshaan merged 1 commit into from
May 20, 2024
Merged

Fix loading state of searching API #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions web-server/src/components/Teams/useTeamsConfig.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,9 +395,7 @@ const useReposSearch = () => {
let cancelTokenSource = axios.CancelToken.source();

const onChange = (e: React.ChangeEvent<HTMLInputElement>) => {
depFn(isLoading.true);
const query = e.target.value;
if (!query) return;
debouncedSearch(query);
};

Expand All @@ -410,10 +408,12 @@ const useReposSearch = () => {

const fetchData = useCallback(
async (query) => {
depFn(isLoading.true);
// cancel the previous request if it exists
if (cancelTokenSource) {
if (cancelTokenSource || !query) {
cancelTokenSource.cancel('Operation canceled due to new request.');
}
if (!query) return depFn(isLoading.false);
// create a new cancel token
cancelTokenSource = axios.CancelToken.source();

Expand Down