Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.2.0 not working for me #11

Closed
richardkall opened this issue Aug 26, 2014 · 16 comments
Closed

v2.2.0 not working for me #11

richardkall opened this issue Aug 26, 2014 · 16 comments

Comments

@richardkall
Copy link

I just tried v2.2.0 but none of my prefixes are generated. When downgrading to v2.1.2 everything is back to normal. Do I need to configure something differently with the new version?

config.rb:

activate :autoprefixer do |config|
  config.browsers = ['last 5 versions', 'Explorer >= 9']
end

CSS:

a {
  transition: transform 1s;
}

Output in v2.1.2:

a {
  -webkit-transition: -webkit-transform 1s;
  transition: transform 1s;
}

Output in v2.2.0:

a {
  transition: transform 1s;
}
@porada
Copy link
Contributor

porada commented Aug 26, 2014

Could you check if different pieces of CSS get prefixed? Example: background: linear-gradient(to bottom, white, black).

@richardkall
Copy link
Author

Just tested, it only outputs

background: linear-gradient(to bottom, white, black); 

No prefixes.

@camskene
Copy link

Prefixes not generated using flexbox and column-count.

@porada
Copy link
Contributor

porada commented Aug 28, 2014

@camskene, what does your browsers config look like? Empty/default?

@camskene
Copy link

I'm using all default settings.

@porada
Copy link
Contributor

porada commented Aug 28, 2014

To be honest, I can’t reproduce this. Can you test your projects against the current master? It makes use of the most up-to-date version of Autoprefixer.

gem 'middleman-autoprefixer', github: 'porada/middleman-autoprefixer'

porada added a commit that referenced this issue Aug 28, 2014
This might be responsible for #11.
@camskene
Copy link

Tested, no prefixes.

2.1.2 is fine.

@porada
Copy link
Contributor

porada commented Aug 28, 2014

@camskene, is your app open source? If not, is there any chance you could give the access to clone it?

@camskene
Copy link

I wouldn't be allowed to give you access to the repo, sorry. I'm using the latest version of MM if that's of any help...

@porada
Copy link
Contributor

porada commented Aug 28, 2014

Okay. Directing the same question to @richardkall, then. 😉

@richardkall
Copy link
Author

I can't give you access, but I'll post the file contents here:

Gemfile

source 'http://rubygems.org'

gem 'middleman', '~> 3.3.5'
gem 'middleman-autoprefixer', '~> 2.2.0'
gem 'middleman-blog', '~> 3.5.3'
gem 'middleman-cloudfront', '~> 0.0.9'
gem 'middleman-imageoptim', '~> 0.1.4'
gem 'middleman-livereload', '~> 3.3.4'
gem 'middleman-minify-html', '~> 3.4.0'
gem 'middleman-s3_sync', '~> 3.0.31'
gem 'middleman-sitemap', '~> 0.0.13'
gem 'middleman-syntax', '~> 2.0.0'
gem 'redcarpet', '~> 3.1.2'
gem 'slim', '~> 2.0.3'

config.rb

activate :blog do |blog|
end

activate :autoprefixer
activate :directory_indexes
activate :imageoptim
activate :livereload
activate :sitemap, hostname: 'http://example.com'
activate :syntax, line_numbers: true

activate :s3_sync do |s3_sync|
  s3_sync.bucket = 'example.com'
  s3_sync.region = 'eu-west-1'
end

activate :cloudfront do |cf|
  cf.access_key_id = ENV['AWS_ACCESS_KEY_ID']
  cf.secret_access_key = ENV['AWS_SECRET_ACCESS_KEY']
  cf.distribution_id = 'XXXXXXXX'
  cf.filter = /\.html|.xml$/i
end

default_caching_policy max_age:(60 * 60 * 24 * 365)
caching_policy 'text/html', max_age: 0, must_revalidate: true

set :css_dir, 'assets/stylesheets'
set :images_dir, 'assets/images'
set :js_dir, 'assets/javascripts'
set :partials_dir, 'partials'

set :markdown_engine, :redcarpet
set :markdown, fenced_code_blocks: true
set :slim, format: :html5

set :ga_tracking_id, 'UA-XXXXXXX'

configure :build do
  activate :asset_hash
  activate :gzip
  activate :minify_css
  activate :minify_html
  activate :minify_javascript, inline: true

  activate :asset_host
  set :asset_host, '//cdn.example.com'
end

Let me know if you need anything else.

@porada
Copy link
Contributor

porada commented Aug 31, 2014

Still can’t reproduce the bug.

Could you paste the following lines at the beginning of your stylesheet and see if -webkit-border-radius gets stripped from the output?

div {
  -webkit-border-radius: 10px;
  border-radius: 10px;
}

@porada
Copy link
Contributor

porada commented Aug 31, 2014

@camskene, are you able to paste your config.rb too?

@camskene
Copy link

camskene commented Sep 1, 2014

I can confirm the -webkit prefix was stripped out when adding border-radius.

@porada
Copy link
Contributor

porada commented Sep 1, 2014

This means that Autoprefixer is working.

FYI, the previous version of the extension (2.1.2) makes use of Autoprefixer 2.2.*, while the most recent one (2.2.0) uses the updated version of Autoprefixer, 3.0.*. You should probably report this as an Autoprefixer issue (and refer to this issue if it’s of any help).

@porada porada closed this as completed Sep 1, 2014
porada added a commit that referenced this issue Oct 18, 2014
@porada
Copy link
Contributor

porada commented Oct 18, 2014

@richardkall @camskene, just a heads up: this issue is finally properly fixed in v2.2.2. Enjoy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants