Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix historical Chromecast sessions hanging around #345

Closed
trueChazza opened this issue Apr 17, 2023 · 1 comment · Fixed by #346
Closed

Fix historical Chromecast sessions hanging around #345

trueChazza opened this issue Apr 17, 2023 · 1 comment · Fixed by #346
Assignees
@trueChazza
Labels
bug Something isn't working
Milestone
v3.1.0

Comments

@trueChazza
Copy link
Member

trueChazza commented Apr 17, 2023 •
edited
Loading

When casting from Android Chrome, sometimes there will be historical sessions hanging around.

This causes strange behaviour when trying to resume normal phone operation - for example using the phone volume slider will change the Chromecast volume instead of the phone volume.
@trueChazza trueChazza converted this from a draft issue Apr 17, 2023
@trueChazza trueChazza self-assigned this Apr 17, 2023
@trueChazza trueChazza added the bug Something isn't working label Apr 17, 2023
@trueChazza trueChazza added this to the v3.1.0 milestone Apr 17, 2023
@trueChazza trueChazza linked a pull request Apr 17, 2023 that will close this issue
v3.1.0 #346
Merged
trueChazza added a commit that referenced this issue Apr 17, 2023
@trueChazza
refactor: page scope chromecast session
83d753d 
closes #345
@trueChazza
Copy link
Member Author

https://developers.google.com/cast/docs/reference/web_sender/chrome.cast#.AutoJoinPolicy

Possibly scoping session to page could fix. Other scopes automatically connect.

@trueChazza trueChazza moved this from Todo to In Progress in midarrlabs Apr 18, 2023
trueChazza added a commit that referenced this issue May 5, 2023
@trueChazza
fix: account for Chromecast sessions when casting
5b56fb8 
closes #345
@github-project-automation github-project-automation bot moved this from In Progress to Done in midarrlabs May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trueChazza trueChazza

Labels
bug Something isn't working
Projects
midarrlabs
Status: Done
Milestone
v3.1.0
Development

Successfully merging a pull request may close this issue.

v3.1.0 midarrlabs/midarr-server
1 participant
@trueChazza