Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attribution back to repository #339

Closed
trueChazza opened this issue Apr 5, 2023 · 1 comment · Fixed by #346
Closed

Add attribution back to repository #339

trueChazza opened this issue Apr 5, 2023 · 1 comment · Fixed by #346
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v3.1.0

Comments

@trueChazza
Copy link
Member

trueChazza commented Apr 5, 2023 •
edited
Loading

Screenshot 2023-04-06 at 10 01 32 AM

This is to have the footer link back to the repository for attribution purposes.
Any concerns or comments about this?

I don't want my users or even myself being bothered by anything else, other than why I use Midarr - to enjoy my media library.

Are you OK with your users being led away from Midarr to the repository if they clicked here?
@trueChazza trueChazza added the request for comments Opportunity to share ideas label Apr 5, 2023
@trueChazza
Copy link
Member Author

https://github.com/midarrlabs/midarr-server/blob/master/lib/media_server_web/components/footer_component.html.heex#L26-L28

Make this a link that opens the repository in a new tab.

@trueChazza trueChazza added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 11, 2023
@trueChazza trueChazza changed the title RFC: attribution back to repository Add attribution back to repository Apr 11, 2023
@trueChazza trueChazza removed the request for comments Opportunity to share ideas label Apr 11, 2023
@trueChazza trueChazza moved this to Todo in midarrlabs Apr 17, 2023
@trueChazza trueChazza added this to the v3.1.0 milestone Apr 17, 2023
@trueChazza trueChazza linked a pull request Apr 17, 2023 that will close this issue
v3.1.0 #346
Merged
trueChazza added a commit that referenced this issue Apr 18, 2023
@trueChazza
feat: add footer attribution
2d6c5c1 
closes #339
@trueChazza trueChazza moved this from Todo to In Progress in midarrlabs Apr 18, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in midarrlabs Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
midarrlabs
Status: Done
Milestone
v3.1.0
Development

Successfully merging a pull request may close this issue.

v3.1.0 midarrlabs/midarr-server
1 participant
@trueChazza