Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when populating command alias value in command metadata JSON #2788

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Jun 12, 2024

Previous check would always set aliases to null when command metadata is being updated post-generation with the latest cmdlets.

Setting null aliases causes unit tests for aliasing in Find-MgGraphCommand to fail, breaking the build pipeline.

(Draft PR: pending a build pipeline run to update the command metadata.json with aliases)

@Ndiritu Ndiritu changed the title Fix bug in populating command alias value in command metadata JSON Fix bug when populating command alias value in command metadata JSON Jun 12, 2024
@Ndiritu Ndiritu force-pushed the fix/command-metadata-alias branch from d9e084d to 42b7dd3 Compare June 13, 2024 08:49
@timayabi2020 timayabi2020 marked this pull request as ready for review June 25, 2024 07:49
@timayabi2020 timayabi2020 requested a review from a team as a code owner June 25, 2024 07:49
@timayabi2020 timayabi2020 merged commit 0917575 into dev Jun 26, 2024
3 checks passed
@timayabi2020 timayabi2020 deleted the fix/command-metadata-alias branch June 26, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants