Skip to content

Backward Compatibility to address issues in 2.17.0 and 2.18.0 #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 9, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Applications/Applications.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,6 @@ directive:
subject: ^(OnPremisePublishingProfile)(\1)+
set:
subject: $1
#Prevent paths from being generated to allow for aliasing as a result of breaking changes in 2.18.0 and 2.17.0
- remove-path-by-operation: ^application_DeleteOwnerGraphBPreRef$|^application_DeleteAppManagementPolicyGraphBPreRef$|^application_DeleteTokenIssuancePolicyGraphBPreRef$|^application_DeleteTokenLifetimePolicyGraphBPreRef$|^servicePrincipal_DeleteClaimsMappingPolicyGraphBPreRef$|^servicePrincipal_DeleteHomeRealmDiscoveryPolicyGraphBPreRef$|^servicePrincipal_DeleteOwnerGraphBPreRef$|^onPremisesPublishingProfile.agentGroup.agent_DeleteAgentGroupGraphBPreRef$|^onPremisesPublishingProfile.connectorGroup_DeleteMemberGraphBPreRef$|^onPremisesPublishingProfile.connector_ListMemberGraphOPreGraphBPreRef$|^onPremisesPublishingProfile.publishedResource_DeleteAgentGroupGraphBPreRef$
```
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,8 @@ private Uri PrepareUri(HttpClient httpClient, Uri uri)
// set body to null to prevent later FillRequestStream
Body = null;
}
return uriBuilder.Uri.EscapeDataStrings();
//Review fix made in https://github.com/microsoftgraph/msgraph-sdk-powershell/pull/2690
return uriBuilder.Uri;
}

private void ThrowIfError(ErrorRecord error)
Expand Down
12 changes: 12 additions & 0 deletions src/Authentication/Authentication/Models/GraphCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ public interface IGraphCommand
/// </summary>
string[] Variants { get; set; }
/// <summary>
/// Command Alias.
/// </summary>
string CommandAlias { get; set ; }
/// <summary>
/// The response type of the command.
/// </summary>
string ApiReferenceLink { get; set; }
/// <summary>
/// The permissions needed to use the command.
/// </summary>
GraphPermission[] Permissions { get; set; }
Expand Down Expand Up @@ -84,6 +92,10 @@ public class GraphCommand : IGraphCommand
/// The permissions needed to use the command.
/// </summary>
public GraphPermission[] Permissions { get; set; }
/// <summary>
/// Command Alias.
/// </summary>
public string CommandAlias { get; set ; }
}

/// <summary>
Expand Down
Loading