Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to send certificate chain for subject name / issuer based auth in Connect-MgGraph #2699

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

nayanshah
Copy link
Contributor

Fixes #2698

Changes proposed in this pull request

Adds a flag SendCertificateChain to Connect-MgGraph to send entire certificate chain while requesting access token. This allows subject name / issuer based auth.

Other links

ClientCertificateCredentialOptions.SendCertificateChain - https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity/src/Credentials/ClientCertificateCredentialOptions.cs

@nayanshah nayanshah requested a review from a team as a code owner April 24, 2024 00:20
Copy link
Contributor

@timayabi2020 timayabi2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend that you add a pester test for the new parameter.

@nayanshah
Copy link
Contributor Author

I don't see any test passing a real certificate or a way to mock the authentication provider, so would be difficult to write a test for the new parameter. The parameter is forwarded to ClientCertificateCredential class which doesn't expose the value as a public member, so not straightforward to add a C# unit test either.

I have updated existing pester test to include the new parameter in the appropriate parameter set. Would that be sufficient given that not much new logic is being added?

@nayanshah nayanshah force-pushed the nayanshah/sni-auth branch from 43e8bab to 632a34a Compare April 24, 2024 07:03
@nayanshah nayanshah requested a review from timayabi2020 April 24, 2024 07:04
@timayabi2020 timayabi2020 merged commit e5183c4 into microsoftgraph:dev Apr 24, 2024
2 checks passed
@nayanshah
Copy link
Contributor Author

Thank you @timayabi2020 . Do you know when is the next release scheduled for?

@timayabi2020
Copy link
Contributor

@nayanshah it will be out by end of this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Subject Name / Issuer based certificate authentication
2 participants