Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orders permissions based on least privilege property value (True or false) #2680

Conversation

timayabi2020
Copy link
Contributor

Fixes #2618

Changes proposed in this pull request

  • Updated NewCommandMetadata.ps1 to order permissions from graphexplorer api based on the least privilege property. (See image below)
  • Updated GraphCommand.cs by adding IsLeastPrivilege property
image

@timayabi2020 timayabi2020 requested a review from a team as a code owner April 15, 2024 17:29
@timayabi2020 timayabi2020 merged commit 20c5f44 into dev Apr 16, 2024
3 checks passed
@timayabi2020 timayabi2020 deleted the 2618-find-mggraphcommand-sorts-required-permissions-alphabetically-not-least-privilege branch April 16, 2024 07:46
@ykuijs
Copy link

ykuijs commented Apr 16, 2024

The sorting looks much better, but there is still one thing that is a bit odd:
The order now lists Organization.ReadWrite.All before Organization.Read.All. I think that should be the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find-MgGraphCommand sorts required permissions alphabetically, not least privilege
3 participants