Skip to content

Conversation

@sebastienlevert
Copy link
Contributor

Design specs for the kiota generated version of the JS SDK.

@sebastienlevert
Copy link
Contributor Author

Before we go any further, I wanted to know if this is helpful and hear from both of you @baywet and @nikithauc. It's absolutely a WIP but I'd love to get early feedback! That will help with defining what is required to make technical decisions! Thanks!

baywet
baywet previously requested changes Jan 17, 2022
@nikithauc
Copy link
Contributor

This could be added in this document too

Tasks constructors such as PageIterator and LargeFileUpload tasks should accept both GraphServiceClient and GraphCoreClient

// both should work
const pageIterator = PageIterator(GraphServiceClient, options);
or
const pageIterator = PageIterator(GraphCoreClient, options);

@sebastienlevert sebastienlevert marked this pull request as ready for review February 15, 2022 20:10
@sebastienlevert sebastienlevert dismissed baywet’s stale review February 15, 2022 20:13

We will be merging the spec in the and then have smaller increments. Will help with the overall discussion!

@sebastienlevert sebastienlevert merged commit f4939cd into microsoftgraph:dev Feb 15, 2022
@sebastienlevert sebastienlevert deleted the sebastienlevert/v4-js-e2e branch February 15, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants