Skip to content

Modifying return type of Onedrive create function #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Modifying return type of Onedrive create function #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tasks/OneDriveLargeFileUploadTask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export class OneDriveLargeFileUploadTask<T> extends LargeFileUploadTask<T> {
* @param {OneDriveLargeFileUploadOptions} options - The options for upload task
* @returns The promise that will be resolves to OneDriveLargeFileUploadTask instance
*/
public static async create(client: Client, file: Blob | Buffer | File, options: OneDriveLargeFileUploadOptions): Promise<unknown> {
public static async create(client: Client, file: Blob | Buffer | File, options: OneDriveLargeFileUploadOptions): Promise<OneDriveLargeFileUploadTask<Blob | ArrayBuffer | Buffer>> {
if (!client || !file || !options) {
throw new GraphClientError("Please provide the Graph client instance, file object and OneDriveLargeFileUploadOptions value");
}
Expand All @@ -112,7 +112,7 @@ export class OneDriveLargeFileUploadTask<T> extends LargeFileUploadTask<T> {
content = b.buffer.slice(b.byteOffset, b.byteOffset + b.byteLength);
}
const fileObj = new FileUpload(content, name, size);
return this.createTaskWithFileObject(client, fileObj, options);
return this.createTaskWithFileObject<Blob | ArrayBuffer | Buffer>(client, fileObj, options);
}

/**
Expand Down