Skip to content

hotfix/msal dependency #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2020
Merged

hotfix/msal dependency #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e0d321
- moves msal dependency to runtime deps
baywet Dec 1, 2020
1c7ef46
2.2.1
baywet Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@microsoft/microsoft-graph-client",
"version": "2.2.0",
"version": "2.2.1",
"description": "Microsoft Graph Client Library",
"license": "MIT",
"main": "lib/src/index.js",
Expand All @@ -13,6 +13,7 @@
"types": "./lib/src/index.d.ts",
"dependencies": {
"@babel/runtime": "^7.4.4",
"msal": "^1.4.4",
Copy link
Contributor

@nikithauc nikithauc Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the msal version change cause any problem ?

Copy link
Member Author

@baywet baywet Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe it will as it was ^1.0.0 which will resolve to 1.4.4 if the consumer hasn't locked to a specific version in their project, or work from a different copy if they have. I can set it to 1.0.0 if you think we should give consumers "more freedom"

"tslib": "^1.9.3"
},
"devDependencies": {
Expand All @@ -27,7 +28,6 @@
"isomorphic-fetch": "^2.2.1",
"lint-staged": "^8.1.5",
"mocha": "^6.1.4",
"msal": "^1.0.0",
"prettier": "^1.17.0",
"rollup": "^1.10.1",
"rollup-plugin-babel": "^4.3.2",
Expand Down
2 changes: 1 addition & 1 deletion src/Version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
* @module Version
*/

export const PACKAGE_VERSION = "2.2.0";
export const PACKAGE_VERSION = "2.2.1";