-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearer middleware chain #1729
base: dev
Are you sure you want to change the base?
Clearer middleware chain #1729
Conversation
@pennane please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Making it safer & more consistent to use the middleware chain with minor changes.
Middleware.setNext()
is now requiredHTTPMessageHandler
.Middleware.#nextMiddleware
is made optionalHTTPClientFactory.createWithAuthenticationProvider
uses theMiddlewareFactory.getDefaultMiddlewareChain
internallyMiddlewareFactory.getDefaultMiddlewareChain
was duplicated prior inHTTPClientFactory.createWithAuthenticationProvider
which could result to accidental logic diversion.Types of changes
Checklist