-
Notifications
You must be signed in to change notification settings - Fork 233
Remove unsupported node versions(12 & 14) from the pipeline #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MIchaelMainer
merged 6 commits into
dev
from
feature/remove-deprecated-node-versions-from-pipeline
Aug 22, 2023
Merged
Remove unsupported node versions(12 & 14) from the pipeline #1405
MIchaelMainer
merged 6 commits into
dev
from
feature/remove-deprecated-node-versions-from-pipeline
Aug 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
suggested changes
Aug 17, 2023
Member
baywet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
baywet
approved these changes
Aug 18, 2023
Member
baywet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes
Contributor
|
Replaces #1403 |
baywet
previously approved these changes
Aug 21, 2023
MIchaelMainer
approved these changes
Aug 21, 2023
Contributor
|
In cases where we remove a workflow that is required by policy, we need to do one of the following actions:
|
baywet
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A similar PR may already be submitted! Please search among the Pull request before creating one.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request.
NOTE: PR's will be accepted only in case of appropriate information is provided below
Summary
Remove versions of node that are no longer supported, 12 & 14, from the pipeline build configuration
Motivation
Explain the motivation for making this change. What existing problem does the pull request solve?
Test plan
Demonstrate the code is solid. Example: The exact commands you ran and their output.
Closing issues
Fixes #
Types of changes
Checklist