Removing rethrown errors

Author: nikithauc

.eslintrc.json

@@ -6,7 +6,7 @@
 	"rules": {
 		"no-useless-catch": "error", //TODO- Remove the unnecessary try-catch lines used and enable no-useless-catch rule.
 		"prefer-rest-params": "off",
-		"no-constant-condition": "off",
+		"no-constant-condition": "error",
 		// @typescript-eslint rules
 		"@typescript-eslint/no-empty-interface": "warn",
 		"@typescript-eslint/ban-types": "off",
@@ -161,8 +161,18 @@
 		"@typescript-eslint/no-empty-function": "error",
 		"@typescript-eslint/no-namespace": "off",
 		"@typescript-eslint/no-parameter-properties": "off",
-
+		"@typescript-eslint/no-array-constructor": "error",
 		// eslint
+		// "sort-imports": [
+		//	"error",
+		//	{
+		//		"ignoreCase": false,
+		//		"ignoreDeclarationSort": false,
+		//		"ignoreMemberSort": false,
+		//		"memberSyntaxSortOrder": ["none", "all", "multiple", "single"],
+		//		"allowSeparatedGroups": false
+		//	}
+		// ],
 		"brace-style": "error",
 		"constructor-super": "error",
 		"curly": ["error", "multi-line"],

src/GraphResponseHandler.ts

@@ -161,25 +161,21 @@ export class GraphResponseHandler {
 	 * @returns The parsed response
 	 */
 	public static async getResponse(rawResponse: Response, responseType?: ResponseType, callback?: GraphRequestCallback): Promise<any> {
-		try {
-			if (responseType === ResponseType.RAW) {
-				return Promise.resolve(rawResponse);
-			} else {
-				const response = await GraphResponseHandler.convertResponse(rawResponse, responseType);
-				if (rawResponse.ok) {
-					// Status Code 2XX
-					if (typeof callback === "function") {
-						callback(null, response);
-					} else {
-						return response;
-					}
+		if (responseType === ResponseType.RAW) {
+			return Promise.resolve(rawResponse);
+		} else {
+			const response = await GraphResponseHandler.convertResponse(rawResponse, responseType);
+			if (rawResponse.ok) {
+				// Status Code 2XX
+				if (typeof callback === "function") {
+					callback(null, response);
 				} else {
-					// NOT OK Response
-					throw response;
+					return response;
 				}
+			} else {
+				// NOT OK Response
+				throw response;
 			}
-		} catch (error) {
-			throw error;
 		}
 	}
 }

src/HTTPClient.ts

@@ -79,17 +79,13 @@ export class HTTPClient {
 	 * @returns A promise that resolves to the Context
 	 */
 	public async sendRequest(context: Context): Promise<Context> {
-		try {
-			if (typeof context.request === "string" && context.options === undefined) {
-				const error = new Error();
-				error.name = "InvalidRequestOptions";
-				error.message = "Unable to execute the middleware, Please provide valid options for a request";
-				throw error;
-			}
-			await this.middleware.execute(context);
-			return context;
-		} catch (error) {
+		if (typeof context.request === "string" && context.options === undefined) {
+			const error = new Error();
+			error.name = "InvalidRequestOptions";
+			error.message = "Unable to execute the middleware, Please provide valid options for a request";
 			throw error;
 		}
+		await this.middleware.execute(context);
+		return context;
 	}
 }

src/browser/ImplicitMSALAuthenticationProvider.ts

@@ -82,12 +82,8 @@ export class ImplicitMSALAuthenticationProvider implements AuthenticationProvide
 				return authResponse.accessToken;
 			} catch (error) {
 				if (error.name === "InteractionRequiredAuthError") {
-					try {
-						const authResponse = await this.msalApplication.acquireTokenPopup(tokenRequest);
-						return authResponse.accessToken;
-					} catch (error) {
-						throw error;
-					}
+					const authResponse = await this.msalApplication.acquireTokenPopup(tokenRequest);
+					return authResponse.accessToken;
 				} else {
 					throw error;
 				}

src/tasks/LargeFileUploadTask.ts

@@ -215,6 +215,7 @@ export class LargeFileUploadTask {
 	 * @returns The promise resolves to uploaded response
 	 */
 	public async upload(): Promise<any> {
+		// eslint-disable-next-line no-constant-condition
 		while (true) {
 			const nextRange = this.getNextRange();
 			if (nextRange.maxValue === -1) {