Removing rethrown errors

Author: nikithauc

.eslintrc.json

@@ -4,11 +4,11 @@
 	"plugins": ["@typescript-eslint", "prettier"],
 	"extends": ["eslint:recommended", "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended", "prettier"],
 	"rules": {
-		"no-useless-catch": "off", //TODO- Remove the unnecessary try-catch lines used and enable no-useless-catch rule.
+		"no-useless-catch": "error", //TODO- Remove the unnecessary try-catch lines used and enable no-useless-catch rule.
 		"prefer-rest-params": "off",
 		"no-constant-condition": "off",
 		// @typescript-eslint rules
-		"@typescript-eslint/no-empty-interface": "off",
+		"@typescript-eslint/no-empty-interface": "warn",
 		"@typescript-eslint/ban-types": "off",
 		"@typescript-eslint/no-unused-vars": "error",
 		"@typescript-eslint/no-explicit-any": "off",
@@ -161,9 +161,9 @@
 		"@typescript-eslint/no-empty-function": "error",
 		"@typescript-eslint/no-namespace": "off",
 		"@typescript-eslint/no-parameter-properties": "off",
+
 		// eslint
-		// eslint
-		"brace-style": "off",
+		"brace-style": "error",
 		"constructor-super": "error",
 		"curly": ["error", "multi-line"],
 		"dot-notation": "off",
@@ -178,7 +178,7 @@
 		"no-fallthrough": "error",
 		"no-new-func": "off",
 		"no-new-wrappers": "error",
-		"no-return-await": "error",
+		"no-return-await": "off",
 		"no-sparse-arrays": "error",
 		"no-template-curly-in-string": "error",
 		"no-throw-literal": "error",

spec/content/BatchRequestContent.ts

@@ -309,13 +309,9 @@ describe("BatchRequestContent.ts", () => {
 		it("Should return json content", async () => {
 			const req = getCreateFolderRequestCopy();
 			const batchReq = new BatchRequestContent([req]);
-			try {
-				const content = await batchReq.getContent();
-				assert.isDefined(content.requests[0].body);
-				assert.equal(typeof content.requests[0].body, "object");
-			} catch (error) {
-				throw error;
-			}
+			const content = await batchReq.getContent();
+			assert.isDefined(content.requests[0].body);
+			assert.equal(typeof content.requests[0].body, "object");
 		});
 
 		it("Should return image's base64 string", async () => {
@@ -335,12 +331,8 @@ describe("BatchRequestContent.ts", () => {
 					}),
 				};
 				const batchReq = new BatchRequestContent([uploadOneDriveFile]);
-				try {
-					const content = await batchReq.getContent();
-					assert.isDefined(content.requests[0].body);
-				} catch (error) {
-					throw error;
-				}
+				const content = await batchReq.getContent();
+				assert.isDefined(content.requests[0].body);
 			});
 		});
 

spec/core/HTTPClient.ts

@@ -63,33 +63,25 @@ describe("HTTPClient.ts", () => {
 		});
 
 		it("Should execute for context object with Request instance", async () => {
-			try {
-				const request: Request = new Request("dummy_url", {
-					method: "GET",
-				});
-				const context: Context = {
-					request,
-				};
-				await httpClient.sendRequest(context);
-			} catch (error) {
-				throw error;
-			}
+			const request: Request = new Request("dummy_url", {
+				method: "GET",
+			});
+			const context: Context = {
+				request,
+			};
+			await httpClient.sendRequest(context);
 		});
 
 		it("Should execute for context object with request uri and options", async () => {
-			try {
-				const url = "dummy_url";
-				const options: FetchOptions = {
-					method: "GET",
-				};
-				const context: Context = {
-					request: url,
-					options,
-				};
-				await httpClient.sendRequest(context);
-			} catch (error) {
-				throw error;
-			}
+			const url = "dummy_url";
+			const options: FetchOptions = {
+				method: "GET",
+			};
+			const context: Context = {
+				request: url,
+				options,
+			};
+			await httpClient.sendRequest(context);
 		});
 	});
 });

spec/middleware/RetryHandler.ts

@@ -148,11 +148,7 @@ describe("RetryHandler.ts", function() {
 
 	describe("sleep", async () => {
 		it("Should run the sleep method for 1 second", async () => {
-			try {
-				await retryHandler["sleep"](1);
-			} catch (error) {
-				throw error;
-			}
+			await retryHandler["sleep"](1);
 		});
 	});
 

spec/middleware/RetryHandlerOptions.ts

@@ -12,14 +12,10 @@ import { RetryHandlerOptions, ShouldRetry } from "../../src/middleware/options/R
 describe("RetryHandlerOptions.ts", () => {
 	describe("Constructor", () => {
 		it("Should use default values if not given", () => {
-			try {
-				const options = new RetryHandlerOptions();
-				assert.equal(options["delay"], RetryHandlerOptions["DEFAULT_DELAY"]);
-				assert.equal(options["maxRetries"], RetryHandlerOptions["DEFAULT_MAX_RETRIES"]);
-				assert.equal(options["shouldRetry"], RetryHandlerOptions["defaultShouldRetry"]);
-			} catch (error) {
-				throw error;
-			}
+			const options = new RetryHandlerOptions();
+			assert.equal(options["delay"], RetryHandlerOptions["DEFAULT_DELAY"]);
+			assert.equal(options["maxRetries"], RetryHandlerOptions["DEFAULT_MAX_RETRIES"]);
+			assert.equal(options["shouldRetry"], RetryHandlerOptions["defaultShouldRetry"]);
 		});
 
 		it("Should throw error for both delay and maxRetries are higher than the limit", () => {
@@ -83,20 +79,16 @@ describe("RetryHandlerOptions.ts", () => {
 		});
 
 		it("Should accept all the given values", () => {
-			try {
-				const delay = 1;
-				const maxRetries = 3;
-				// eslint-disable-next-line @typescript-eslint/no-unused-vars
-				const shouldRetry: ShouldRetry = (d, a, req, o, res) => {
-					return false;
-				};
-				const options = new RetryHandlerOptions(delay, maxRetries, shouldRetry);
-				assert.equal(options.delay, delay);
-				assert.equal(options.maxRetries, maxRetries);
-				assert.equal(options.shouldRetry, shouldRetry);
-			} catch (error) {
-				throw error;
-			}
+			const delay = 1;
+			const maxRetries = 3;
+			// eslint-disable-next-line @typescript-eslint/no-unused-vars
+			const shouldRetry: ShouldRetry = (d, a, req, o, res) => {
+				return false;
+			};
+			const options = new RetryHandlerOptions(delay, maxRetries, shouldRetry);
+			assert.equal(options.delay, delay);
+			assert.equal(options.maxRetries, maxRetries);
+			assert.equal(options.shouldRetry, shouldRetry);
 		});
 	});
 

spec/tasks/PageIterator.ts

@@ -75,84 +75,56 @@ describe("PageIterator.ts", () => {
 	describe("iterate", () => {
 		it("Should iterate over a complete collection without nextLink", async () => {
 			const pageIterator = new PageIterator(client, getPageCollection(), truthyCallback);
-			try {
-				await pageIterator.iterate();
-				assert.isTrue(pageIterator.isComplete());
-			} catch (error) {
-				throw error;
-			}
+			await pageIterator.iterate();
+			assert.isTrue(pageIterator.isComplete());
 		});
 
 		it("Should not iterate over an empty collection", async () => {
 			const pageIterator = new PageIterator(client, getEmptyPageCollection(), truthyCallback);
 			halfWayCallbackCounter = 1;
-			try {
-				await pageIterator.iterate();
-				assert.equal(halfWayCallbackCounter, 1);
-			} catch (error) {
-				throw error;
-			}
+			await pageIterator.iterate();
+			assert.equal(halfWayCallbackCounter, 1);
 		});
 
 		it("Should break in the middle way", async () => {
 			const pageIterator = new PageIterator(client, getPageCollection(), halfWayCallback);
 			halfWayCallbackCounter = 5;
-			try {
-				await pageIterator.iterate();
-				assert.isFalse(pageIterator.isComplete());
-			} catch (error) {
-				throw error;
-			}
+			await pageIterator.iterate();
+			assert.isFalse(pageIterator.isComplete());
 		});
 	});
 
 	describe("iterationHelper", () => {
 		it("Should return true for empty collection with next link", () => {
 			const pageIterator = new PageIterator(client, getEmptyPageCollectionWithNext(), truthyCallback);
-			try {
-				const advance = pageIterator["iterationHelper"]();
-				assert.isTrue(advance);
-			} catch (error) {
-				throw error;
-			}
+			const advance = pageIterator["iterationHelper"]();
+			assert.isTrue(advance);
 		});
 	});
 
 	describe("resume", () => {
 		it("Should start from the place where it left the iteration", async () => {
 			const pageIterator = new PageIterator(client, getPageCollection(), halfWayCallback);
 			halfWayCallbackCounter = 5;
-			try {
-				await pageIterator.iterate();
-				assert.isFalse(pageIterator.isComplete());
-				await pageIterator.resume();
-				assert.isTrue(pageIterator.isComplete());
-			} catch (error) {
-				throw error;
-			}
+			await pageIterator.iterate();
+			assert.isFalse(pageIterator.isComplete());
+			await pageIterator.resume();
+			assert.isTrue(pageIterator.isComplete());
 		});
 	});
 
 	describe("isComplete", () => {
 		it("Should return false for incomplete iteration", async () => {
 			const pageIterator = new PageIterator(client, getPageCollection(), halfWayCallback);
 			halfWayCallbackCounter = 5;
-			try {
-				await pageIterator.iterate();
-				assert.isFalse(pageIterator.isComplete());
-			} catch (error) {
-				throw error;
-			}
+			await pageIterator.iterate();
+			assert.isFalse(pageIterator.isComplete());
 		});
 
 		it("Should return true for complete iteration", async () => {
 			const pageIterator = new PageIterator(client, getPageCollection(), truthyCallback);
-			try {
-				await pageIterator.iterate();
-				assert.isTrue(pageIterator.isComplete());
-			} catch (error) {
-				throw error;
-			}
+			await pageIterator.iterate();
+			assert.isTrue(pageIterator.isComplete());
 		});
 	});
 });

src/Client.ts

@@ -60,11 +60,7 @@ export class Client {
 	 * @returns The Client instance
 	 */
 	public static initWithMiddleware(clientOptions: ClientOptions): Client {
-		try {
-			return new Client(clientOptions);
-		} catch (error) {
-			throw error;
-		}
+		return new Client(clientOptions);
 	}
 
 	/**
@@ -74,11 +70,7 @@ export class Client {
 	 * @param {ClientOptions} clientOptions - The options to instantiate the client object
 	 */
 	private constructor(clientOptions: ClientOptions) {
-		try {
-			validatePolyFilling();
-		} catch (error) {
-			throw error;
-		}
+		validatePolyFilling();
 		for (const key in clientOptions) {
 			if (Object.prototype.hasOwnProperty.call(clientOptions, key)) {
 				this.config[key] = clientOptions[key];