Skip to content

Conversation

@mtgerb
Copy link

@mtgerb mtgerb commented Feb 10, 2021

Fixes #659

Changes proposed in this pull request

  • Fix typo in BaseCollectionRequest setMaxRetries method, which caused the maximum redirects to be set instead of maximum retries

@mtgerb mtgerb changed the title #659 Fix BaseCollectionRequest setMaxRetries method Fix BaseCollectionRequest setMaxRetries method Feb 10, 2021
@baywet baywet self-assigned this Feb 10, 2021
@baywet baywet added this to the 2.8.0 milestone Feb 10, 2021
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution @mtgerb !!
Everything looks good. Merging

@baywet baywet merged commit 32d6eea into microsoftgraph:dev Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling setMaxRetries on BaseCollectionRequest sets maxRedirects on baseRequest

3 participants