feature/generic request #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaces older, native client dependent implementation by a new implementation for batches
- fixes a bug where the batch request method would not be cased properly
baywet
requested review from
MIchaelMainer,
ddyett,
nikithauc and
zengin
as code owners
This was
linked to
issues
Feb 5, 2021
Closed
Closed
baywet
force-pushed
the
feature/generic-request
branch
from
cd1679b to
a1b7d30
Compare
This was referenced Feb 5, 2021
Closed
Closed
Contributor
|
This looks good. Just a though, did you consider having a IRequest interface which captures what you need from the request? This might not work if you need to pass exactly a okhttp3 request somewhere. Oh, but you wouldn't be able to implement that interface on the okhttp3 request.... Yeah this approach is fine. |
zengin
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests unties the interfaces and domain requests from the native http client request types. Allowing customers who'd like to do so to use their own native client while keeping authentication handlers, serialization, generated types and more.
fixes #113
fixes #106