-
Notifications
You must be signed in to change notification settings - Fork 62
Proper Batching support #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper Batching support #613
Conversation
andrueastman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @svrooij
Just a couple of suggestions from my side
src/Microsoft.Graph.Core/Requests/Content/BatchRequestContentCollection.cs
Show resolved
Hide resolved
src/Microsoft.Graph.Core/Requests/Content/KeyedBatchResponseContent.cs
Outdated
Show resolved
Hide resolved
As suggested by @andrueastman
|
@andrueastman Great suggestions. Code maid helped me cleanup the code a bit. And converted the IEnumerable to a HashSet |
andrueastman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for taking the time to make the contribution @svrooij
|
As a new contributor can you please explain how the release will go @andrueastman ? |
|
We should see the release deployed after #614 is merged. |
Fixes #612
Changes proposed in this pull request
Other links
As promised to @maisarissi a PR with my extension code integrated in the Graph SDK for dotnet.
Microsoft Reviewers: Open in CodeFlow