Skip to content

Conversation

@svrooij
Copy link
Contributor

@svrooij svrooij commented Mar 3, 2023

Fixes #612

Changes proposed in this pull request

  • Automatically splitting batch requests into multiple batches without the user having to manage it.

Other links

As promised to @maisarissi a PR with my extension code integrated in the Graph SDK for dotnet.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @svrooij

Just a couple of suggestions from my side

@svrooij
Copy link
Contributor Author

svrooij commented Mar 6, 2023

@andrueastman Great suggestions.

Code maid helped me cleanup the code a bit. And converted the IEnumerable to a HashSet

@andrueastman andrueastman enabled auto-merge March 7, 2023 06:15
Copy link
Contributor

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for taking the time to make the contribution @svrooij

@andrueastman andrueastman merged commit 6668ac2 into microsoftgraph:dev Mar 7, 2023
@svrooij
Copy link
Contributor Author

svrooij commented Mar 7, 2023

As a new contributor can you please explain how the release will go @andrueastman ?
Is it automatically, or do you have a certain release cycle?

@andrueastman andrueastman mentioned this pull request Mar 7, 2023
@andrueastman
Copy link
Contributor

We should see the release deployed after #614 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate improving batching support

2 participants