-
Notifications
You must be signed in to change notification settings - Fork 17
Introduce CustomHosts option
#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -18,11 +18,31 @@ There are two primary usage scenarios for the client factory. Developers who wi | |||||
| - Set the SdkVersion header with the appropriate moniker based on the following structure `graph-{lang}-{version}`. | ||||||
| - Enable the developer to select a supported sovereign cloud using an enumerated list. Selecting the sovereign cloud should ensure that the AuthenticationProvider uses the appropriate Authentication Endpoint. | ||||||
| - Enable a developer to configure a HTTP proxy that will be used for outgoing requests. | ||||||
|
|
||||||
| - Enable a developer to provide custom hosts. | ||||||
| - `CustomHosts` option should be set on client creation. | ||||||
| - `CustomHosts` option should be made available in the `Context` so that it is available to the middleware during request processing. | ||||||
| - These URLs are different from the Graph service endpoints on the national clouds. | ||||||
| - Certain workloads error out when an unexpected header is present in the request. The middlewares should check: | ||||||
| - If the request URL is a Graph service endpoint or a custom host provided by the developer, then append request headers or modify the request content. | ||||||
| - Else the middleware should delete request headers added by that middleware. | ||||||
MIchaelMainer marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| - Example of an workload error - [LargeFileUploadTask upload to OneDrive caused CORS error due `SDKVersion` telemetry header](https://github.com/microsoftgraph/msgraph-sdk-javascript/issues/265) | ||||||
| - Provide capabilities to modify or update the `CustomURLs` option after the client creation. | ||||||
|
||||||
| - Provide capabilities to modify or update the `CustomURLs` option after the client creation. | |
| - Provide capabilities to modify or update the `CustomHosts` option after the client creation. |
nikithauc marked this conversation as resolved.
Show resolved
Hide resolved
nikithauc marked this conversation as resolved.
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.