Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop keydown from bubbling beyond people-picker #2892

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix: stop keydown from bubbling beyond people-picker #2892

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eda539
fix: stop keydown from bubbling beyond people-picker
gavinbarron Nov 30, 2023
4e1d505
Merge branch 'main' into fix/people-picker-search-input
gavinbarron Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/mgt-components/src/components/mgt-people-picker/mgt-people-picker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,6 +1548,7 @@ export class MgtPeoplePicker extends MgtTemplatedComponent {
* @param event - event tracked on user input (keydown)
*/
private readonly onUserKeyDown = (event: KeyboardEvent): void => {
event.stopPropagation();
const keyName = event.key;
const selectedList = this.renderRoot.querySelector('.selected-list');
const isCmdOrCtrlKey = event.getModifierState('Control') || event.getModifierState('Meta');
Expand Down Expand Up @@ -1595,7 +1596,6 @@ export class MgtPeoplePicker extends MgtTemplatedComponent {
if (keyName === 'Enter') {
if (!event.shiftKey && this._foundPeople) {
event.preventDefault();
event.stopPropagation();

const foundPerson = this._foundPeople[this._arrowSelectionCount];
if (foundPerson) {
Expand All @@ -1613,10 +1613,6 @@ export class MgtPeoplePicker extends MgtTemplatedComponent {
}
}

if (keyName === 'Escape') {
event.stopPropagation();
}

if (keyName === 'Tab') {
this.hideFlyout();
}
Expand Down
Loading