Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: combobox attributes #2538

Merged
merged 5 commits into from
Jun 25, 2023
Merged

fix: combobox attributes #2538

merged 5 commits into from
Jun 25, 2023

Conversation

gavinbarron
Copy link
Member

Closes #2532

PR Type

  • Bugfix

Description of the changes

Adds required aria attributes for combo box usage on mgt-people-picker and mgt-team-channel-picker

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Passes fast pass validation when expanded and collapsed
Seems to provide sensible narration when testing with a screen reader.

@gavinbarron gavinbarron requested a review from a team as a code owner June 22, 2023 23:38
@ghost
Copy link

ghost commented Jun 22, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron enabled auto-merge (squash) June 22, 2023 23:39
@sebastienlevert sebastienlevert changed the title Fix/combobox attributes fix: combobox attributes Jun 23, 2023
@github-actions
Copy link

The updated storybook is available here

@sebastienlevert sebastienlevert linked an issue Jun 23, 2023 that may be closed by this pull request
[A11y] people picker and teams channel picker are missing required aria attributes #2532
Closed
@github-actions
Copy link

The updated storybook is available here

1 similar comment
@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@gavinbarron gavinbarron merged commit b89f045 into next/fluentui Jun 25, 2023
@gavinbarron gavinbarron deleted the fix/combobox-attributes branch June 25, 2023 16:06
This was referenced Jul 17, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlevert sebastienlevert sebastienlevert approved these changes

Assignees
No one assigned
Labels
Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A11y] people picker and teams channel picker are missing required aria attributes
2 participants
@gavinbarron @sebastienlevert