Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Returning a JSON parsed version of the cache for insights types #2524

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

sebastienlevert
Copy link
Contributor

Closes #2523

PR Type

  • Bugfix

Description of the changes

Returning a JSON parsed version of the cache for insights types. It was returning directly fileList.files but the files were still raw JSON.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

@sebastienlevert sebastienlevert requested a review from a team as a code owner June 21, 2023 16:53
@ghost
Copy link

ghost commented Jun 21, 2023

Thank you for creating a Pull Request @sebastienlevert.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@sebastienlevert sebastienlevert changed the base branch from main to next/fluentui June 21, 2023 16:54
gavinbarron
gavinbarron previously approved these changes Jun 21, 2023
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] mgt-file-list is broken when using cached data in an insight result
2 participants