Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: caching story #2516

Merged
merged 4 commits into from
Jun 21, 2023
Merged

fix: caching story #2516

merged 4 commits into from
Jun 21, 2023

Conversation

gavinbarron
Copy link
Member

Closes #2506

PR Type

  • Bugfix

Description of the changes

updates caching story to use new api
makes clearCacheById return a Promise to allow developer to await completion of cache clearing

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

updates caching story to use new api
makes clearCacheById return a Promise to allow developer to await completion of cache clearing
@gavinbarron gavinbarron requested a review from a team as a code owner June 20, 2023 22:59
@ghost
Copy link

ghost commented Jun 20, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron linked an issue Jun 20, 2023 that may be closed by this pull request
@github-actions
Copy link

The updated storybook is available here

Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@sebastienlevert sebastienlevert enabled auto-merge (squash) June 21, 2023 00:32
@github-actions
Copy link

The updated storybook is available here

1 similar comment
@github-actions
Copy link

The updated storybook is available here

@sebastienlevert sebastienlevert merged commit 2bd21d1 into next/fluentui Jun 21, 2023
@sebastienlevert sebastienlevert deleted the fix/caching-story branch June 21, 2023 00:59
@github-actions
Copy link

The updated storybook is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Fix caching story
2 participants