Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sample electron app fixes #2482

Merged
merged 5 commits into from
Jun 20, 2023
Merged

fix: sample electron app fixes #2482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0dae2d1
fix: sample electron app fixes
gavinbarron Jun 16, 2023
8896ced
adding note on WSL use to readme
gavinbarron Jun 16, 2023
0b17362
Merge branch 'next/fluentui' into fix/electron-sample
musale Jun 20, 2023
7a4f05f
Merge branch 'next/fluentui' into fix/electron-sample
gavinbarron Jun 20, 2023
d701a43
Merge branch 'next/fluentui' into fix/electron-sample
gavinbarron Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/mgt-components/src/components/mgt-person/mgt-person.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ $person-line4-text-line-height: var(--person-line4-text-line-height, 16px);
&.small {
.avatar-wrapper {
min-width: $person-avatar-size;
width: $person-avatar-size;
height: $person-avatar-size;
}
}
Expand All @@ -83,6 +84,7 @@ $person-line4-text-line-height: var(--person-line4-text-line-height, 16px);
&.twolines {
.avatar-wrapper {
min-width: $person-avatar-size-40;
width: $person-avatar-size-40;
height: $person-avatar-size-40;

.initials,
Expand All @@ -103,6 +105,7 @@ $person-line4-text-line-height: var(--person-line4-text-line-height, 16px);
&.large {
.avatar-wrapper {
min-width: $person-avatar-size-56;
width: $person-avatar-size-56;
height: $person-avatar-size-56;

.initials,
Expand All @@ -121,6 +124,7 @@ $person-line4-text-line-height: var(--person-line4-text-line-height, 16px);

&.fourlines {
.avatar-wrapper {
min-width: $person-avatar-size-72;
width: $person-avatar-size-72;
height: $person-avatar-size-72;

Expand All @@ -145,6 +149,7 @@ $person-line4-text-line-height: var(--person-line4-text-line-height, 16px);

.avatar-wrapper {
min-width: $person-avatar-size-72;
width: $person-avatar-size-72;
height: $person-avatar-size-72;

.initials,
Expand All @@ -163,6 +168,7 @@ $person-line4-text-line-height: var(--person-line4-text-line-height, 16px);

.avatar-wrapper {
min-width: $person-avatar-size;
width: $person-avatar-size;
height: $person-avatar-size;
position: relative;
box-sizing: border-box;
Expand Down
2 changes: 2 additions & 0 deletions samples/electron-app/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The `@microsoft/mgt-electron-provider` package exposes the `ElectronAuthenticato

This sample shows how the ElectronProvider works in a simple Electron application.

This sample shows how the ElectronProvider works in a simple Electron application. This sample does not work when using WSL, it has been tested and validated using Windows due to the challenges running applications with a GUI from WSL.

# To Use

## In root of repo install all dependencies and build all packages
Expand Down
3 changes: 2 additions & 1 deletion samples/electron-app/src/main/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ export default class Main {
'presence.read',
'user.read.all',
'group.read.all',
'tasks.read'
'tasks.read',
'team.readbasic.all'
],
//SimpleCachePlugin is used here as an example. It stores unencrypted tokens directly on your machine, so please only use it for testing purposes
cachePlugin: SimpleCachePlugin
Expand Down