Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max picker list height #2431

Merged
merged 2 commits into from
Jun 12, 2023
Merged

fix: max picker list height #2431

merged 2 commits into from
Jun 12, 2023

Conversation

gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Jun 9, 2023

Closes #2421

PR Type

  • Bugfix

Description of the changes

adds a new variable to set the max height of the mgt-picker list defaults the max height of the mgt-picker list to 380px

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR: Link to docs PR here
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

adds a new variable to set the max height of the mgt-picker list
defaults the max height of the mgt-picker list to 380px
@gavinbarron gavinbarron requested a review from a team as a code owner June 9, 2023 21:54
@ghost
Copy link

ghost commented Jun 9, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

The updated storybook is available here

Mnickii
Mnickii previously approved these changes Jun 12, 2023
@github-actions
Copy link

The updated storybook is available here

@musale musale merged commit 7a22138 into next/fluentui Jun 12, 2023
@musale musale deleted the fix/picker-height branch June 12, 2023 12:15
@gavinbarron gavinbarron linked an issue Jun 12, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] mgt-picker should provide "internal" scrolling on long lists
3 participants