Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add todo custom properties story #2412

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Jun 6, 2023

Closes #2410

PR Type

Bugfix

Description of the changes

Add a story for todo custom properties

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner June 6, 2023 13:57
@ghost
Copy link

ghost commented Jun 6, 2023

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@Mnickii Mnickii linked an issue Jun 6, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

The updated storybook is available here

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

The updated storybook is available here

@Mnickii Mnickii enabled auto-merge (squash) June 7, 2023 06:25
@Mnickii Mnickii merged commit ff5ea0b into next/fluentui Jun 7, 2023
@Mnickii Mnickii deleted the todo-custom-properties-storybook branch June 7, 2023 06:35
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

The updated storybook is available here

@Mnickii Mnickii added this to the v3.0.0 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[mgt-todo] Include styles story in mgt-todo
3 participants