Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support target-id and initial-id attributes in mgt-todo #2407

Merged
merged 9 commits into from
Jun 13, 2023
Merged

fix: support target-id and initial-id attributes in mgt-todo #2407

merged 9 commits into from
Jun 13, 2023

Conversation

musale
Copy link
Contributor

@musale musale commented Jun 6, 2023

Closes #2266

PR Type

  • Bugfix

Description of the changes

  • Added support for target ID which renders the tasks for the target ID that has been passed and displays the target name.
  • Added support for the initial ID that sets the display name of the initial ID list as the default and renders the tasks that it has.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale added this to the 2023-06 milestone Jun 6, 2023
@musale musale requested a review from a team as a code owner June 6, 2023 11:45
@ghost
Copy link

ghost commented Jun 6, 2023

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@musale musale linked an issue Jun 6, 2023 that may be closed by this pull request
[BUG] mgt-todo doesn't support initial-id and target-id #2266
Closed
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

The updated storybook is available here

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

The updated storybook is available here

gavinbarron
gavinbarron requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @musale let's get clarification on the default load state, as in v2 the default behavior matches the ToDo service and fix up the stories

@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

The updated storybook is available here

@musale @gavinbarron
Change the default task ID
2cf4d41 
Co-authored-by: Gavin Barron <[email protected]>
@ghost ghost removed the Needs: Author Feedback Issue needs response from issue author label Jun 9, 2023
@musale @gavinbarron
Change the default task ID
f4f2f65 
Co-authored-by: Gavin Barron <[email protected]>
@gavinbarron
Copy link
Member

@musale there are conflicts here to resolve

@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@sebastienlevert sebastienlevert self-requested a review June 12, 2023 17:33
sebastienlevert
sebastienlevert previously approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@github-actions
Copy link

The updated storybook is available here

1 similar comment
@github-actions
Copy link

The updated storybook is available here

@gavinbarron
Copy link
Member

@musale there's a linting issue blocking this from building correctly

@musale
Fix eslint issues
1cf5f22 
Signed-off-by: Martin Musale <[email protected]>
@github-actions
Copy link

The updated storybook is available here

gavinbarron
gavinbarron approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gavinbarron gavinbarron enabled auto-merge (squash) June 13, 2023 19:46
@gavinbarron gavinbarron merged commit f2d4668 into next/fluentui Jun 13, 2023
@gavinbarron gavinbarron deleted the bug-2266 branch June 13, 2023 19:54
@github-actions
Copy link

The updated storybook is available here

@sebastienlevert sebastienlevert modified the milestones: 2023-06, v3.0.0 Jun 15, 2023
This was referenced Jul 17, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@sebastienlevert sebastienlevert Awaiting requested review from sebastienlevert

Assignees
No one assigned
Labels
Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

[BUG] mgt-todo doesn't support initial-id and target-id
3 participants
@musale @gavinbarron @sebastienlevert