Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make spfx version script work for rc version #2396

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

gavinbarron
Copy link
Member

Fix to spfx publishing script to allow for correct publishing when version being published uses the -rc.* suffix

@gavinbarron gavinbarron requested a review from a team as a code owner June 2, 2023 22:56
@ghost
Copy link

ghost commented Jun 2, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron enabled auto-merge (squash) June 2, 2023 22:56
@gavinbarron gavinbarron merged commit 2d953fa into next/fluentui Jun 2, 2023
@gavinbarron gavinbarron deleted the fix/spfx-publish-for-rc branch June 2, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants