Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set react peer dependency as range #2393

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Jun 2, 2023

Closes #2392

PR Type

  • Bugfix

Description of the changes

Set semver range for React peer dependency
This is linked to #2063

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

The semver range of ^17.0.1 || ^18.0.0 was tested using https://semver.npmjs.com/

@gavinbarron gavinbarron requested a review from a team as a code owner June 2, 2023 18:25
@ghost
Copy link

ghost commented Jun 2, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron enabled auto-merge (squash) June 2, 2023 18:34
@gavinbarron gavinbarron merged commit 2ee0078 into next/fluentui Jun 2, 2023
@gavinbarron gavinbarron deleted the fix/react-peer-dep-range branch June 2, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants