Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove react peer dependency #2389

Merged
merged 1 commit into from
Jun 2, 2023
Merged

fix: remove react peer dependency #2389

merged 1 commit into from
Jun 2, 2023

Conversation

gavinbarron
Copy link
Member

Closes #2386

PR Type

  • Bugfix

Description of the changes

removes react peer dependency.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@gavinbarron gavinbarron requested a review from a team as a code owner June 2, 2023 16:58
@ghost
Copy link

ghost commented Jun 2, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron enabled auto-merge (squash) June 2, 2023 16:59
@gavinbarron gavinbarron merged commit 4025f6f into main Jun 2, 2023
@gavinbarron gavinbarron deleted the fix/react-peer-deps branch June 2, 2023 17:00
sebastienlevert pushed a commit that referenced this pull request Jun 23, 2023
* fix: remove react peer dependency (#2389)

* fix: add top to the caching key to allow varying values with different page sizes (#2406)

Signed-off-by: Martin Musale <[email protected]>

* chore: capture all branch protection policy (#2430)

* chore: capture all branch protection policy
* wrap pattern in quotes

* fix: set requiresStrictStatusChecks to false

requiresStrictStatusChecks should be false if we don't have one or more status checks defined in requiredStatusChecks property.

---------

Signed-off-by: Martin Musale <[email protected]>
Co-authored-by: Musale Martin <[email protected]>
Co-authored-by: Michael Mainer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] unable to resolve dependency tree peer react@"^17.0.1" from @microsoft/[email protected]
2 participants