Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change override design token logic #2384

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Jun 1, 2023

Closes #2327

PR Type

  • Bugfix

Description of the changes

now sets design token values via functions exposed by fluent to ensure they are used inside nested cards

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

now sets design token values via functions exposed by fluent to ensure they are used inside nested cards
@gavinbarron gavinbarron requested a review from a team as a code owner June 1, 2023 22:36
@ghost
Copy link

ghost commented Jun 1, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron linked an issue Jun 1, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

The updated storybook is available here

Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's more pop in the dark mode colors,

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

The updated storybook is available here

@gavinbarron gavinbarron merged commit ed6c9b3 into next/fluentui Jun 2, 2023
@gavinbarron gavinbarron deleted the fix/theme-overrides branch June 2, 2023 15:40
@gavinbarron gavinbarron linked an issue Jun 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Channel picker offers to use saved data [BUG] Dark mode blue colors are not quite right
2 participants