Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch off completed-docs JSDoc rule #2278

Merged
merged 2 commits into from
May 11, 2023

Conversation

musale
Copy link
Contributor

@musale musale commented May 11, 2023

PR Type

  • Code style update (linting)

Description of the changes

Switched off the completed-docs rule. It's raising toot many false positives.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Signed-off-by: Musale Martin <[email protected]>
@musale musale requested review from gavinbarron and Mnickii May 11, 2023 10:24
@ghost
Copy link

ghost commented May 11, 2023

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron merged commit 73a3882 into next/fluentui May 11, 2023
@gavinbarron gavinbarron deleted the completed-docs-off branch May 11, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants