Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: voice over for person in list #2206

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Conversation

gavinbarron
Copy link
Member

Closes #2120

PR Type

  • Bugfix

Description of the changes

Conditionally removes tabindex attribute allowing voice over to see inside the html for mgt-person when nested inside an html element with the role menuitem

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Conditionally removes tabindex attribute allowing voice over to see inside the html for mgt-person when nested inside an html element with the role menuitem
@ghost
Copy link

ghost commented Apr 21, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

The updated storybook is available here

@gavinbarron gavinbarron requested a review from Mnickii April 21, 2023 19:49
@gavinbarron gavinbarron enabled auto-merge (squash) April 21, 2023 19:50
@sebastienlevert sebastienlevert self-requested a review April 24, 2023 19:24
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great to see a new story for that!

@gavinbarron gavinbarron merged commit c60567d into main Apr 24, 2023
@gavinbarron gavinbarron deleted the bug/voice-over-person-in-list branch April 24, 2023 19:34
@github-actions
Copy link

The updated storybook is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

{Linked:Bug3432717}[BUG] Voiceover does not announce the Person component if present in List component
2 participants