Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added spec for mgt-taxonomy-picker #2156

Merged

Conversation

anoopt
Copy link
Contributor

@anoopt anoopt commented Mar 29, 2023

refs: #634

PR Type

Other: Added spec for mgt-taxonomy-picker

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Details

Added spec for mgt-taxonomy-picker. The spec needs to be reviewed.

@ghost
Copy link

ghost commented Mar 29, 2023

Thank you for creating a Pull Request @anoopt.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the spec! Simple and neat. Couple change requests but mainly I think we're good to go! Thanks for this new component, we're really excited you're taking advantage of the mgt-picker foundation to build this component!

@ghost ghost added Needs: Author Feedback Issue needs response from issue author and removed Needs: Author Feedback Issue needs response from issue author labels Apr 3, 2023
@sebastienlevert sebastienlevert enabled auto-merge (squash) April 6, 2023 17:30
@sebastienlevert sebastienlevert merged commit 670a3cb into microsoftgraph:next/fluentui Apr 6, 2023
@anoopt
Copy link
Contributor Author

anoopt commented Apr 6, 2023

Thank you for the reviews @musale and @sebastienlevert . I will proceed with developing the component. Shall I target the same branch for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants