Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: unselect person focus indicator on webkit #2060

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

gavinbarron
Copy link
Member

makes the focus indicator visible on webkit browsers when attempting to remove an item from the people picker selected list

Closes #1949

PR Type

  • Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • Accessibility tested and approved
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

makes the focus indicator visible on webkit browsers when attempting to remove an item from the people picker selected list
@ghost
Copy link

ghost commented Feb 27, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron enabled auto-merge (squash) February 28, 2023 04:16
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinbarron gavinbarron merged commit 4b6474f into main Mar 1, 2023
@gavinbarron gavinbarron deleted the bug/people-picker-unselect-focus-webkit branch March 1, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants