feat: file grid #2057
feat: file grid #2057
Conversation
adds a new component to allow switching in the ui between light and dark modes adds a theme toggle to all stories by default updates developer test page to include toggle adds helper functions to assist with theme changing using fluentui web components theming tools
adds a file grid option to the file-list-composite
|
Thank you for creating a Pull Request @gavinbarron. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
There was a problem hiding this comment.
Shall we remove the breadcrumbs story since we have the file-composite component? https://mgt.dev/next/?path=/story/components-mgt-file-list--open-folder-breadcrumbs
No, I think we'll leave that as a standalone component. as folks can use it independently of the file composite. However, we should expose it as a React component too |
|
The updated storybook is available here |
|
The updated storybook is available here |
It is. If you set the page-size value to 5 you see only 5 items. However, there is an existing bug in the file-list caching where values page-size is not considered during caching, so when you change the page-size to 20 without changing the underlying query being made to something not cached there is a cache hit and you see only the 10 results fetched by default. Bug added to track caching issue separately #2147 |
|
The updated storybook is available here |
|
The updated storybook is available here |
|
|
The updated storybook is available here |
| f => f.id, | ||
| f => html` | ||
| <div | ||
| class="${this.isSelected(f) ? 'file-row selected' : 'file-row'}" |
There was a problem hiding this comment.
| class="${this.isSelected(f) ? 'file-row selected' : 'file-row'}" | |
| class="${classMap({'file-row': true, selected: this.isSelected(f)})}" |
|
When interacting with the first 3 menu items on a file, they appear on top of the dialog/modal that is supposed to be active.
|
|
The updated storybook is available here |
|
The updated storybook is available here |
|
The updated storybook is available here |
|
The updated storybook is available here |
|
The updated storybook is available here |
Closes #
PR Type
Description of the changes
Adds a file grid view with per item context menus to perform file actions
PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information