Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: disambiguation simplification for non-react solutions #2054

Merged
merged 5 commits into from
Feb 23, 2023

Conversation

gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Feb 23, 2023

Closes #2055

PR Type

  • Documentation content changes

Description of the changes

I worked out that we don't need the import helper for SPFx webparts that don't use the React wrapper as the browser will automatically attach behavior to existing tags in the DOM.

This PR updates the documentation, removes the unnecessary helper function and updates the sample webpart

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

@gavinbarron gavinbarron marked this pull request as ready for review February 23, 2023 03:02
@ghost
Copy link

ghost commented Feb 23, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron enabled auto-merge (squash) February 23, 2023 18:07
@gavinbarron gavinbarron merged commit e8531bd into next/fluentui Feb 23, 2023
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components.mgt-person 50% 42% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 30% 13% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 19% 8% 0
mgt-components.src.styles 90% 57% 0
mgt-components.src.utils 36% 4% 0
mgt-element.src 42% 0% 0
mgt-element.src.components 40% 0% 0
mgt-element.src.mock 53% 45% 0
mgt-element.src.providers 38% 22% 0
mgt-element.src.utils 43% 24% 0
providers.mgt-msal-provider.src 46% 38% 0
Summary 37% (709 / 1904) 20% (228 / 1114) 0

@gavinbarron gavinbarron deleted the next/disambiguation-util-fixes branch June 27, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs + Sample] Disambiguation without React can be vastly simplified
2 participants