Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Storybook authentication #2048

Merged
merged 14 commits into from
Mar 29, 2023
Merged

feat: Storybook authentication #2048

merged 14 commits into from
Mar 29, 2023

Conversation

sebastienlevert
Copy link
Contributor

Closes #

PR Type

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Feb 20, 2023

Thank you for creating a Pull Request @sebastienlevert.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@sebastienlevert sebastienlevert changed the title feat: Storrybook authentication feat: Storybook authentication Feb 20, 2023
@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

gavinbarron
gavinbarron requested changes Feb 22, 2023
View reviewed changes
@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label Feb 22, 2023
@github-actions
Copy link

The updated storybook is available here

@musale
Copy link
Contributor

musale commented Feb 23, 2023 •
edited
Loading

@sebastienlevert the logged in user icon is missing now. I logged in yesterday. Today, I got the login popup and then the icon was missing. The data is correct which means I'm logged in correctly just not showing.

image

@ghost ghost added the no-recent-activity label Mar 2, 2023
@ghost
Copy link

ghost commented Mar 2, 2023

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

The updated storybook is available here

@ghost ghost removed the no-recent-activity label Mar 2, 2023
@sebastienlevert
Copy link
Contributor Author

I think it's redirect issues. I need to figure out how to make this work outside of the simple "localhost" context.

@ghost ghost removed the Needs: Author Feedback Issue needs response from issue author label Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

The updated storybook is available here

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

The updated storybook is available here

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

The updated storybook is available here

@sebastienlevert sebastienlevert marked this pull request as ready for review March 10, 2023 20:45
@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

gavinbarron
gavinbarron reviewed Mar 13, 2023
View reviewed changes
Mnickii
Mnickii approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@Mnickii Mnickii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@github-actions
Copy link

The updated storybook is available here

@Mnickii Mnickii mentioned this pull request Mar 16, 2023
Merged
6 tasks
@github-actions
Copy link

The updated storybook is available here

1 similar comment
@github-actions
Copy link

The updated storybook is available here

@gavinbarron gavinbarron merged commit 9af2bf5 into next/fluentui Mar 29, 2023
@gavinbarron gavinbarron deleted the sebastienlevert/storybook-auth branch March 29, 2023 22:27
This was referenced Jul 17, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@musale musale musale approved these changes

@Mnickii Mnickii Mnickii approved these changes

Assignees
No one assigned
Labels
Build: Storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebastienlevert @musale @gavinbarron @Mnickii