Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove angular sample package-lock from repo #2042

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

gavinbarron
Copy link
Member

Closes #2041

PR Type

  • Build or CI related changes

Description of the changes

removes package-lock.json for angular sample application

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

this will reduce the number of dependabot changes when we release new versions
@ghost
Copy link

ghost commented Feb 14, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron enabled auto-merge (squash) February 14, 2023 18:09
@gavinbarron gavinbarron merged commit 2af47c4 into main Feb 14, 2023
@gavinbarron gavinbarron deleted the chore/angular-sample-ignore-package-lock branch February 14, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore] Reduce dependabot nags on angular sample app
2 participants