-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: PeoplePicker add removePerson safety input check #2033
Fix: PeoplePicker add removePerson safety input check #2033
Conversation
Thank you for creating a Pull Request @masashiswingle. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @masashiswingle
Nice catch on this case, could you please make a small style adjustment?
packages/mgt-components/src/components/mgt-people-picker/mgt-people-picker.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Gavin Barron <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go! Thank you @masashiswingle for this patch!
Closes #1997
#1997
PR Type
BugFix
Description of the changes
PeoplePicker Component
Safety checks this.input in the removePerson function. This.input can become null when selectionMode="single" and the a person is selected.
PR checklist
Stories have been added and existing stories have been tested