Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: people picker state management #2028

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

gavinbarron
Copy link
Member

Closes #1644

PR Type

  • Bugfix

Description of the changes

fixes state update triggers in people-picker
updating react sample app to test functionality
adds story to show async setting of defaultSelectedUserIds property

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

updating react sample app to test functionality
adds story to show async setting of defaultSelectedUserIds property
@ghost
Copy link

ghost commented Feb 7, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

The updated storybook is available here

@gavinbarron gavinbarron merged commit b38f17f into main Feb 10, 2023
@gavinbarron gavinbarron deleted the bug/people-picker-state-updates branch February 10, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
2 participants