Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: send notification to teamsfx when new version released #1994

Conversation

SLdragon
Copy link
Contributor

Closes #

PR Type

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Jan 11, 2023

Thank you for creating a Pull Request @SLdragon.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@SLdragon
Copy link
Contributor Author

SLdragon commented Jan 11, 2023

Background

TeamsFx repo is using Graph Toolkit library in Teams Tab APP template for user to easily develop Teams APPs.

This PR updates the stable release workflow to send notification to TeamsFx repo, so that developer and tester in TeamsFx team can quickly catch up the latest release of Graph Toolkit library, then they can update the template and start test it.

Following ups

Due to TeamsFx repo and Graph Toolkit are different repo, so the send notification step need TeamsFx repo access token to make it work.
image

@sebastienlevert
I will ask our manager to generate an access token, and will share the token with you in Teams meeting.

Please do not merge this PR before everything is ready, thank you!

@SLdragon
Copy link
Contributor Author

Hi, @gavinbarron , seems @sebastienlevert is OOF recently, could you also help take a look about this RP, thank you!

@gavinbarron
Copy link
Member

@SLdragon I'm happy to help here. The one thing that does spring to mind is that we'll need to set up a cadence to renew the PAT stored in our secrets.

@SLdragon
Copy link
Contributor Author

I'm happy to help here. The one thing that does spring to mind is that we'll need to set up a cadence to renew the PAT stored in our secrets.

Sure, I will take with my team members about this. Due to we are on Chinese New Year holiday, and I will be back after 1.31 to talk with you about this, thank you very much!

@gavinbarron gavinbarron merged commit 6011ad6 into microsoftgraph:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants