Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next/node16 support #1911

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Next/node16 support #1911

merged 3 commits into from
Oct 26, 2022

Conversation

gavinbarron
Copy link
Member

Closes #1910

PR Type

Feature

Description of the changes

Updates dependencies to allow for building using NodeJS 16 and add CI builds using NodeJS version 14.x and 16.x

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

This should be self testing with the new PR builds :)

Updates dependencies to allow for developer to build using NodeJS
@ghost
Copy link

ghost commented Oct 21, 2022

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

The updated storybook is available here

@sebastienlevert
Copy link
Contributor

I think we should also update :

  • push-release.yml
  • storybook.yml
  • pr-clean-storybook.yml
  • push.yml
  • next.yml

Or at least, clean those to not use the strategy?

@gavinbarron gavinbarron linked an issue Oct 24, 2022 that may be closed by this pull request
@gavinbarron
Copy link
Member Author

I've taken the approach of updating the other workflows to use node 16 and only having the PR workflow use the matrix.

This gives us confidence that changes made will build on node 12, 14, and 16 while only building deployable packages for NPM or storybook using the latest version.

@github-actions
Copy link

The updated storybook is available here

@gavinbarron gavinbarron merged commit a573bdf into next/fluentui Oct 26, 2022
@gavinbarron gavinbarron linked an issue Nov 8, 2022 that may be closed by this pull request
@gavinbarron gavinbarron deleted the next/node16-support branch June 27, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update mgt core packages to build using Node 12-16
3 participants