feat: add custom element disambiguation #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a customElementHelper to allow vendors to add a disambiguation to mgt element names Adds a custom mgtHtml wrapper overtop of html from lit
fixed React code generation
|
The updated storybook is available here |
remove disambiguation from analytics header
|
The updated storybook is available here |
musale
reviewed
Sep 12, 2022
|
The updated storybook is available here |
musale
approved these changes
Sep 12, 2022
…onent registration
|
The updated storybook is available here |
|
The updated storybook is available here |
There was a problem hiding this comment.
Looks really cool! From what I can see, with the default configuration it's backwards compatible, because the default prefix is mgt- but offers the ability to define a solution-specific prefix. Are there any drawbacks that you're aware of that we should into consideration?
|
The updated storybook is available here |
|
The updated storybook is available here |
musale
reviewed
Oct 25, 2022
Co-authored-by: Musale Martin <[email protected]>
|
The updated storybook is available here |
waldekmastykarz
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1765
PR Type
Feature
Description of the changes
Adds the ability for developers to add a custom segment to the custom elements registered with the browser.
Provides a new
customElementdecorator to wrap the lit implementation and set tag prefixes appropriately.Updates all usages of customElement to use the mgt specific implementation
Adds a new
mgtHtmlstring literal tag function to dynamically rewrite mgt tags as needed at runtime which wraps thehtmltag function fromlitUpdates SCSS to avoid using element name based CSS selectors and adds classes to elements in markup where needed.
Updates React generator script to use base tag names.
Updates Mgt React wraper to add the appropriate prefix to tags being written to the DOM.
Updates React sample app to demonstrate usage of
customElementHelper.withDisambiguation('foo').PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information