-
Notifications
You must be signed in to change notification settings - Fork 36
Update Get-EntraUserCertificateUserIdsFromCertificate.ps1 #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Learn Build status updates of commit 676cbd7: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
hi @tomatsue, could you please elaborate on why you believe reversing the byte order is unnecessary? The However, for certificate-based authentication—specifically for the certificateUserIds configuration—the serial number must be in big-endian format to follow the original format that you would see with |
Hi @thadumi, thank you for checking. I've found a problem with the results of Get-EntraUserCertificateUserIdsFromCertificate. This command returns the IssuerAndSerialNumber value — for example, "X509:DC=com,DC=contoso,CN=CONTOSO-DC-CAeF3gH4iJ5kL6mN7oP8qR9sV0uD", which is supposed to be used as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for identifying the bug. Only now I've noticed that this method is using GetSerialNumber() and not the SerialNumber propertly
Learn Build status updates of commit d9ee186: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
It's not necessary to reverse the little-endian data.
Learn Build status updates of commit 1ad7879: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
@tomatsue Fix failing unit tests |
It's not necessary to reverse the little-endian data.