Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Fly-io.flyctl version 0.0.450 #94699

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Jan 26, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 26, 2023
@ghost
Copy link

ghost commented Jan 26, 2023

Hello @sitiom,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.4 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 26, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Jan 26, 2023

winget validate locally fails with this error:

Manifest validation failed.
Manifest Error: Duplicate relative file path found. [RelativeFilePath]
Manifest Error: Duplicate relative file path found. [RelativeFilePath]

flyctl.exe expects two aliases: flyctl and fly. See microsoft/winget-cli#2523 (comment):

Portable Installer Type doesn't throw an error when two entries have the same RelativeFilePath

  • This might be acceptable as long as they have different command aliases?

I guess duplicate relative file path is checked, but not for the exception when they have two different aliases.

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 26, 2023
@Trenly
Copy link
Contributor

Trenly commented Jan 26, 2023

1.4 manifests are still waiting for winget 1.4 to hit a majority of users. It will be a few more days until Zip manifests can be merged

@denelon denelon added Blocking-Issue Manifest validation is blocked by a known issue. .zip labels Jan 26, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Jan 26, 2023

Please see microsoft/winget-cli#2884

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Manifest-Validation-Error Manifest validation failed Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 27, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 27, 2023
@ghost
Copy link

ghost commented Jan 27, 2023

Hello @sitiom,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.4 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 27, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Jan 27, 2023

Validation now succeeds locally:
image

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 27, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Jan 28, 2023

@sitiom sitiom marked this pull request as draft January 28, 2023 01:15
@Trenly
Copy link
Contributor

Trenly commented Feb 9, 2023

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 9, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 9, 2023
@microsoft-github-policy-service
Copy link
Contributor

wingetbot,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@Trenly
Copy link
Contributor

Trenly commented Feb 9, 2023

Seems to work for me

--> Installing WinGet
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
Admin setting enabled.

--> Installing the Manifest 0.0.450

Found flyctl [Fly-io.flyctl] Version 0.0.450
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/superfly/flyctl/releases/download/v0.0.450/flyctl_0.0.450_Windows_x86_64.zip
  ██████████████████████████████  24.7 MB / 24.7 MB
Successfully verified installer hash
Extracting archive...
Successfully extracted archive
Starting package install...
Command line alias added: "flyctl"
Command line alias added: "fly"
Path environment variable modified; restart your shell to use the new value.
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName DisplayVersion Publisher ProductCode
----------- -------------- --------- -----------
flyctl      0.0.450        Fly.io    Fly-io.flyctl__DefaultSource

PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> flyctl
This is flyctl, the Fly.io command line interface.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 9, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello microsoft-github-policy-service[bot],
Validation has completed.

Template: msftbot/validationCompleted

@sitiom
Copy link
Contributor Author

sitiom commented Feb 9, 2023

Seems to work for me

--> Installing WinGet
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
Admin setting enabled.

--> Installing the Manifest 0.0.450

Found flyctl [Fly-io.flyctl] Version 0.0.450
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/superfly/flyctl/releases/download/v0.0.450/flyctl_0.0.450_Windows_x86_64.zip
  ██████████████████████████████  24.7 MB / 24.7 MB
Successfully verified installer hash
Extracting archive...
Successfully extracted archive
Starting package install...
Command line alias added: "flyctl"
Command line alias added: "fly"
Path environment variable modified; restart your shell to use the new value.
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName DisplayVersion Publisher ProductCode
----------- -------------- --------- -----------
flyctl      0.0.450        Fly.io    Fly-io.flyctl__DefaultSource

PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> flyctl
This is flyctl, the Fly.io command line interface.

wintun.dll is lazy loaded for certain commands, that would be an issue.

@denelon
Copy link
Contributor

denelon commented Feb 13, 2023

@sitom if you'd like us to merge this one, it needs to be converted to a PR from a Draft.

@sitiom sitiom marked this pull request as ready for review February 13, 2023 23:26
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Feb 14, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello wingetbot,
Validation has completed.

Template: msftbot/validationCompleted

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 9b7556f into microsoft:master Feb 14, 2023
@sitiom sitiom deleted the Fly-io.flyctl-0.0.450-1F1AC6AC423A2 branch February 14, 2023 00:09
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants