Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting RoslynPad version 19.0.0 #90739

Merged
merged 8 commits into from
Dec 1, 2023

Conversation

aelij
Copy link
Member

@aelij aelij commented Dec 7, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Dec 7, 2022
@ghost
Copy link

ghost commented Dec 7, 2022

Hello @aelij,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.2 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Dec 7, 2022
@ghost ghost assigned aelij Dec 7, 2022
@ghost
Copy link

ghost commented Dec 7, 2022

Hello @aelij,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@Trenly
Copy link
Contributor

Trenly commented Dec 7, 2022

@msftbot zip

@ghost ghost added .zip Blocking-Issue Manifest validation is blocked by a known issue. labels Dec 7, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Manifest-Validation-Error Manifest validation failed Blocking-Issue Manifest validation is blocked by a known issue. labels Dec 7, 2022
@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Dec 7, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Dec 7, 2022
@ghost
Copy link

ghost commented Dec 7, 2022

Hello @aelij,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.2 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Dec 7, 2022
@aelij
Copy link
Member Author

aelij commented Dec 7, 2022

@Trenly the validation is failing because I've used schema version 1.4.0 (needed to support zip). Can this PR be merged now or do I need to wait for a non-preview release of winget that supports it?

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 7, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed the Manifest-Validation-Error Manifest validation failed label Dec 7, 2022
@aelij
Copy link
Member Author

aelij commented Aug 2, 2023

@ItzLevvie I've updated the package to the latest release. Can this be merged now?

@ItzLevvie
Copy link
Contributor

[Policy] Blocking-Issue

@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Aug 3, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Blocking-Issue Manifest validation is blocked by a known issue. label Nov 28, 2023
@aelij aelij changed the title Submitting RoslynPad version 18.0.0 Submitting RoslynPad version 19.0.0 Nov 28, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Nov 28, 2023
@stephengillie
Copy link
Collaborator

Manual Validation ended with:
image

@stephengillie
Copy link
Collaborator

Hi @aelij,

This package displays the above message even with Microsoft.DotNet.AspNetCore.8 preinstalled. Can you help me to find the correct dependency?

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Nov 28, 2023
@aelij
Copy link
Member Author

aelij commented Nov 28, 2023

@stephengillie the app needs a .NET SDK of any supported version. It should not be a dependency, as the users can choose the version according to their needs.

If you want to try out the app you can install Microsoft.DotNet.Sdk.8.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 28, 2023
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Dec 1, 2023
@stephengillie
Copy link
Collaborator

I'll consider this to be normal program operation. We're working on a kind of wildcard system for dependencies, which might allow any .NET SDK to be selected, and could be a better solution for this situation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 1, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 72d70ed into microsoft:master Dec 1, 2023
7 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Dependencies Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants