Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zip][Portable] New package: Gyan.FFmpeg version 5.1.2 #87327

Merged

Conversation

SpecterShell
Copy link
Contributor

@SpecterShell SpecterShell commented Nov 3, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@SpecterShell SpecterShell changed the title New package: Gyan.CodexFFmpeg version 5.1.2 [Zip][Portable] New package: Gyan.CodexFFmpeg version 5.1.2 Nov 3, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Nov 3, 2022
@ghost
Copy link

ghost commented Nov 3, 2022

Hello @SpecterShell,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.2 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 3, 2022
@Trenly
Copy link
Contributor

Trenly commented Nov 4, 2022

@Msftbot .zip

@ghost ghost added .zip Blocking-Issue Manifest validation is blocked by a known issue. labels Nov 4, 2022
@ghost ghost removed Manifest-Validation-Error Manifest validation failed Blocking-Issue Manifest validation is blocked by a known issue. labels Nov 5, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Nov 5, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Nov 5, 2022
@ghost
Copy link

ghost commented Nov 5, 2022

Hello @SpecterShell,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.2 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 5, 2022
ItzLevvie
ItzLevvie previously approved these changes Nov 8, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 8, 2022
@ItzLevvie
Copy link
Contributor

@msftbot .zip

@ghost ghost added the Blocking-Issue Manifest validation is blocked by a known issue. label Nov 9, 2022
@KaranKad
Copy link
Contributor

As this build is officially promoted by ffmpeg site should we change PackageIdentifier to FFmpeg.FFmpeg?

@SpecterShell
Copy link
Contributor Author

As this build is officially promoted by ffmpeg site should we change PackageIdentifier to FFmpeg.FFmpeg?

FFmpeg promotes two different builds:

https://www.gyan.dev/ffmpeg/builds/
https://github.com/BtbN/FFmpeg-Builds/releases

So I use this complicated PackageIdentifier in case another one would be added to winget-pkgs repo as well.
Don't worry. I have added a moniker ffmpeg so that if user types winget install ffmpeg it will install this one by default.

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 10, 2022
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jan 31, 2023
@ghost ghost assigned stephengillie and zachcarp Jan 31, 2023
@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Executable-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Completed Validation passed label Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephengillie stephengillie merged commit 80115b9 into microsoft:master Feb 1, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Feb 1, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@wingetbot wingetbot added the Internal-Error An unidentified error occurred in the validation pipeline label Feb 2, 2023
@SpecterShell SpecterShell deleted the Gyan.CodexFFmpeg-5.1.2-Newpackage branch February 2, 2023 04:41
@mstevens83
Copy link

After installation this does not work for me. It seems like the aliases are incorrect.
@rlaphoenix reported the same issue but it seems his post got deleted?

@sitiom
Copy link
Contributor

sitiom commented Feb 2, 2023

After installation this does not work for me. It seems like the aliases are incorrect. @rlaphoenix reported the same issue but it seems his post got deleted?

@mstevens83 Works fine.
image

@mstevens83
Copy link

mstevens83 commented Feb 2, 2023

Works fine.

Not for me.

It seems like this got added to my PATH: C:\Users\steven89\AppData\Local\Microsoft\WinGet\Packages\Gyan.FFmpeg_Microsoft.Winget.Source_8wekyb3d8bbwe\
But the exe's live 2 folders deeper:
C:\Users\steven89\AppData\Local\Microsoft\WinGet\Packages\Gyan.FFmpeg_Microsoft.Winget.Source_8wekyb3d8bbwe\ffmpeg-5.1.2-full_build\bin

I noticed an issue #95349 was filed for this, I'll join the conversation over there.

@rlaphoenix
Copy link

After installation this does not work for me. It seems like the aliases are incorrect. @rlaphoenix reported the same issue but it seems his post got deleted?

I deleted as I moved discussion to #95349 and I invite you guys to as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Internal-Error An unidentified error occurred in the validation pipeline Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Retry-1 flag to indicate retried Validation-Completed Validation passed Validation-Executable-Error Waived-Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package Request: ffmpeg