Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitch.TwitchStudio version 0.104.7 #34777

Merged
5 commits merged into from
Nov 14, 2021
Merged

Twitch.TwitchStudio version 0.104.7 #34777

5 commits merged into from
Nov 14, 2021

Conversation

sanyer
Copy link
Contributor

@sanyer sanyer commented Nov 13, 2021 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Nov 13, 2021
@ghost
Copy link

ghost commented Nov 13, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

jedieaston
jedieaston suggested changes Nov 13, 2021
View reviewed changes
Copy link
Contributor

@jedieaston jedieaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change the folder name too.

manifests/t/Twitch/TwitchStudio/0.104.7/Twitch.TwitchStudio.installer.yaml Outdated Show resolved Hide resolved
manifests/t/Twitch/TwitchStudio/0.104.7/Twitch.TwitchStudio.locale.en-US.yaml Outdated Show resolved Hide resolved
manifests/t/Twitch/TwitchStudio/0.104.7/Twitch.TwitchStudio.yaml Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 13, 2021
@ghost ghost removed Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Nov 14, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Nov 14, 2021
@ghost
Copy link

ghost commented Nov 14, 2021

Hello @sanyer,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 14, 2021
@jedieaston
Copy link
Contributor

Hot tip to change the folder name: Press "." on your keyboard when you have GitHub open to this PR in your browser, and a web version of VSCode will launch.

Once it loads, find the files you added, and rename the folder. Then use the source control button on the left to commit (it's automatically pushed).

image

@ghost ghost removed Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed labels Nov 14, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sanyer
Copy link
Contributor Author

sanyer commented Nov 14, 2021

oh, that's sick new addition! Thanks for the tip :-D

btw, what can you say about the fact that version 8.0.0 is not a version of the Twitch apps, but instead is their wrapper's (or something)?
The real version is available only for Twitch Studio, though.

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Nov 14, 2021
@ghost
Copy link

ghost commented Nov 14, 2021

Hello @sanyer,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 14, 2021
@jedieaston
Copy link
Contributor

btw, what can you say about the fact that version 8.0.0 is not a version of the Twitch apps, but instead is their wrapper's (or something)?

I'm not sure why that is (ISVs be crazy :D) but we probably need to use that version number since it's the one in the ARP table so winget can detect it. There will be mitigations for this in schema v1.1 (no eta yet on that though).

@sanyer
Copy link
Contributor Author

sanyer commented Nov 14, 2021

btw, what can you say about the fact that version 8.0.0 is not a version of the Twitch apps, but instead is their wrapper's (or something)?

I'm not sure why that is (ISVs be crazy :D) but we probably need to use that version number since it's the one in the ARP table so winget can detect it. There will be mitigations for this in schema v1.1 (no eta yet on that though).

so, v1.1 is not live yet? Links are available at aka.ms.

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 14, 2021
@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Nov 14, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jedieaston
Copy link
Contributor

Schema 1.1 is finalized, but it hasn’t been implemented in the client (the one to many ARP relationship hasn’t been, anyway).

@sanyer
Copy link
Contributor Author

sanyer commented Nov 14, 2021

.

Schema 1.1 is finalized, but it hasn’t been implemented in the client (the one to many ARP relationship hasn’t been, anyway).

oh, ok, got it.
Is there a documentation for the changes?

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Nov 14, 2021
@ghost
Copy link

ghost commented Nov 14, 2021

Hello @sanyer,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 14, 2021
@ghost ghost removed Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed labels Nov 14, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 14, 2021
@jedieaston
Copy link
Contributor

Is there a documentation for the changes?

Not yet. The best I know of is this issue: microsoft/winget-cli#1243.

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Nov 14, 2021
@ghost
Copy link

ghost commented Nov 14, 2021

Hello @sanyer,
Validation has completed.

@ghost ghost merged commit 9df887d into microsoft:master Nov 14, 2021
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@sanyer sanyer deleted the autogenerated/Twitch.TwitchStudio/a7c08551-05a0-4bcf-a79a-e5bbf4030616 branch November 15, 2021 13:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedieaston jedieaston jedieaston approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanyer @wingetbot @jedieaston