Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QOwnNotes 21.7.4 #20295

Closed
wants to merge 1 commit into from
Closed

Add QOwnNotes 21.7.4 #20295

wants to merge 1 commit into from

Conversation

pbek
Copy link

@pbek pbek commented Jul 9, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jul 9, 2021
@ghost
Copy link

ghost commented Jul 9, 2021

Hello @pbek,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jul 9, 2021
@ImJoakim
Copy link
Contributor

ImJoakim commented Jul 9, 2021

Hey @pbek, there is currently no support for zip files.

@pbek
Copy link
Author

pbek commented Jul 9, 2021

Thank you for letting me know, @ImJoakim. Too bad I didn't find that out before the ordeal of creating the manifest files. 😅

@ghost ghost added Needs: Attention and removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jul 9, 2021
@pbek
Copy link
Author

pbek commented Jul 9, 2021

@ImJoakim
Copy link
Contributor

ImJoakim commented Jul 9, 2021

Seems like this issue regarding zip files is this open:

microsoft/winget-cli#140

Hopefully we will see support for this down the line 😃

Edit: And this #174

@pbek
Copy link
Author

pbek commented Jul 9, 2021

Thank you, I'll subscribe those!

Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since .zip files aren't currently supported in the client, would you like to close the PR for now and open it back up when support has been added?

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jul 9, 2021
@pbek pbek closed this Jul 9, 2021
@pbek
Copy link
Author

pbek commented Jul 9, 2021

Btw. would it work to create an "exe" from a self extracting zip and use that?

@ghost ghost removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jul 9, 2021
@denelon
Copy link
Contributor

denelon commented Jul 15, 2021

@pbek that wouldn't work just yet either. We're adding support for complex installers in the schema for 1.1, but the client implementation to handle the various .zip and self extracting .exe are still not at the top of the to do list yet. We're currently focusing on things to improve the install/upgrade/import success rates.

@pbek
Copy link
Author

pbek commented Jul 15, 2021

Ok, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Validation-Installation-Error Error installing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants